Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose TestThread-Container correctly #135

Merged
merged 6 commits into from
May 22, 2024
Merged

Dispose TestThread-Container correctly #135

merged 6 commits into from
May 22, 2024

Conversation

obligaron
Copy link
Contributor

Fixes #123

Remember created TestThread-container and dispose them after test run.
Added a test that ensures that TestThread is initialized and disposed only once.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Performance improvement
  • Refactoring (so no functional change)
  • Other (docs, build config, etc)

Checklist:

  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@obligaron obligaron force-pushed the fix-123-dispose-testthread-container branch from fe48701 to 0a64004 Compare May 17, 2024 19:25
gasparnagy added 5 commits May 22, 2024 14:01
@gasparnagy
Merge remote-tracking branch 'origin/main' into fix-123-dispose-testt…
9821917 
…hread-container

* origin/main:
  Extract cucumber expression detection heuristic to an interface
  fix test artifact folder calculation
  Restructure solution folders (#141)
  cleanup CHANGELOG.md
  ignore generated file
  remove generated file
  bump version
  Add Microsoft.Extensions.DependencyInjection integration plugin (#94)
  Fix #56 autofac ambiguous stepdef and hook required #127 issue (#139)
  Reduce target framework of Reqnroll to netstandard2.0 (#130)
  Fix StackOverflowException when using [StepArgumentTransformation] with same input and output type (#136)

# Conflicts:
#	CHANGELOG.md
@gasparnagy
use _testRunnerRegistry directly to access test thread containers, ad…
4f27c6d 
…d unit test
@gasparnagy
undo system tests
f7f9435
@gasparnagy
cleanup TestRunnerManagerTests
43a0096
@gasparnagy
cleanup TestRunnerManager
6ae091e
@gasparnagy
Copy link
Contributor

@obligaron thx for taking care of it. The concept was good and I kept it, but I have made some simplifications:

  • the test thread container can be accessed from the test runner, so we do not need to keep a separate list of the active ones
  • replaced the system tests with unit tests

@gasparnagy gasparnagy merged commit 3ae913a into main May 22, 2024
4 checks passed
@gasparnagy gasparnagy deleted the fix-123-dispose-testthread-container branch May 22, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gasparnagy gasparnagy gasparnagy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dispose method is not called on objects registered for the TestThread container
2 participants
@obligaron @gasparnagy